Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed portuguese entry in VOCAB #571

Merged
merged 1 commit into from
Nov 1, 2021

Conversation

fmobrj
Copy link
Contributor

@fmobrj fmobrj commented Nov 1, 2021

Refactored portuguese entry in VOCAB as suggested by @fg-mindee.

@codecov
Copy link

codecov bot commented Nov 1, 2021

Codecov Report

Merging #571 (92a5bcb) into main (b149266) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #571   +/-   ##
=======================================
  Coverage   96.06%   96.06%           
=======================================
  Files         109      109           
  Lines        4198     4198           
=======================================
  Hits         4033     4033           
  Misses        165      165           
Flag Coverage Δ
unittests 96.06% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/datasets/vocabs.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b149266...92a5bcb. Read the comment docs.

@fg-mindee fg-mindee self-requested a review November 1, 2021 18:18
@fg-mindee fg-mindee self-assigned this Nov 1, 2021
@fg-mindee fg-mindee added the module: datasets Related to doctr.datasets label Nov 1, 2021
@fg-mindee fg-mindee added this to the 0.4.1 milestone Nov 1, 2021
@fg-mindee fg-mindee added the type: bug Something isn't working label Nov 1, 2021
Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@fg-mindee fg-mindee changed the title feat: Refactored portuguese entry in VOCAB fix: Fixed portuguese entry in VOCAB Nov 1, 2021
@fg-mindee fg-mindee merged commit b27c3a6 into mindee:main Nov 1, 2021
@fmobrj
Copy link
Contributor Author

fmobrj commented Nov 1, 2021

Thanks for the fix!

You are welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: datasets Related to doctr.datasets type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants