Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added support of AMP to all PyTorch training scripts #604

Merged
merged 9 commits into from
Nov 10, 2021
Merged

Conversation

fg-mindee
Copy link
Contributor

This PR introduces the following modifications:

  • added option to run the training in AMP
  • updated information logged into W&B
  • fixed sample plotting in trainings
  • fixed compatibility of DBNet with data type different from fp32

Any feedback is welcome!

@fg-mindee fg-mindee added type: enhancement Improvement module: models Related to doctr.models ext: references Related to references folder framework: pytorch Related to PyTorch backend labels Nov 10, 2021
@fg-mindee fg-mindee added this to the 0.5.0 milestone Nov 10, 2021
@fg-mindee fg-mindee self-assigned this Nov 10, 2021
@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #604 (a4de6c4) into main (2335b6f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #604   +/-   ##
=======================================
  Coverage   96.06%   96.06%           
=======================================
  Files         110      110           
  Lines        4265     4265           
=======================================
  Hits         4097     4097           
  Misses        168      168           
Flag Coverage Δ
unittests 96.06% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/models/detection/core.py 97.61% <100.00%> (ø)
doctr/utils/geometry.py 98.78% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2335b6f...a4de6c4. Read the comment docs.

Copy link
Collaborator

@charlesmindee charlesmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fg-mindee fg-mindee merged commit 250a3cb into main Nov 10, 2021
@fg-mindee fg-mindee deleted the amp-pt branch November 10, 2021 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: references Related to references folder framework: pytorch Related to PyTorch backend module: models Related to doctr.models type: enhancement Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants