Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 deprecated streamlit version in demo app #611

Merged
merged 21 commits into from
Nov 12, 2021
Merged

Conversation

charlesmindee
Copy link
Collaborator

This PR updates the min. Streamlit version to 1.0.0 (major released in october), older versions are deprecated with the use of columns.

Any feedback is welcome!

@charlesmindee charlesmindee self-assigned this Nov 12, 2021
@charlesmindee charlesmindee added the type: bug Something isn't working label Nov 12, 2021
@charlesmindee charlesmindee added this to the 0.4.1 milestone Nov 12, 2021
@fg-mindee fg-mindee added the ext: demo Related to demo folder label Nov 12, 2021
Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me!

@codecov
Copy link

codecov bot commented Nov 12, 2021

Codecov Report

Merging #611 (8379e62) into main (a792a82) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #611      +/-   ##
==========================================
+ Coverage   96.03%   96.06%   +0.02%     
==========================================
  Files         110      110              
  Lines        4265     4265              
==========================================
+ Hits         4096     4097       +1     
+ Misses        169      168       -1     
Flag Coverage Δ
unittests 96.06% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...dels/detection/differentiable_binarization/base.py 91.82% <0.00%> (+0.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a792a82...8379e62. Read the comment docs.

@charlesmindee charlesmindee merged commit f97e92b into main Nov 12, 2021
@charlesmindee charlesmindee deleted the req_stream branch November 12, 2021 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: demo Related to demo folder type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants