-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ✨ allow beam width > 1 in the CRNN postprocessor #630
Conversation
Codecov Report
@@ Coverage Diff @@
## main #630 +/- ##
=======================================
Coverage 94.92% 94.93%
=======================================
Files 133 133
Lines 5281 5288 +7
=======================================
+ Hits 5013 5020 +7
Misses 268 268
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This PR solves #602 for exporting CRNN recognition models as saved models . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this feature, but we may want to keep the same input/output format to avoid breaking the predictors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As Charles mentioned, there are some parts of this PR that could be integrated and others that introduce breaking changes, that cannot be handled right now :/
I think we should split this into 2 PRs:
- one to fix SavedModel compatibility
- one to add topk
@khalidMindee is this PR still good? If yes, can you review FG's & @charlesmindee comments, modify in consequences so we can potentially merge it please? |
8691196
to
8d4a8c1
Compare
This PR has been updated accordingly to keep only allowing beam width , postponning the fix for exporting the saved model as it introduces a breaking change due to signature change |
8d4a8c1
to
8c82f29
Compare
… add unit test for inference using crnn with beam_search
8c82f29
to
5aeb02d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Hey @charlesmindee 👋 |
Missing two labels "module: models" and "ext: test" I think @charlesmindee :) |
This PR aims to allow beam search decoding in CRNN postprocessing , instead of only greedy decoding ( corresponding to a beam search with beam width equal to 1 )