Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refacto: 🔧 postprocessing with rotated boxes #641

Merged
merged 14 commits into from
Nov 23, 2021

Conversation

charlesmindee
Copy link
Collaborator

Following #632 and #551, this PR removes deprecated flags and deprecated page-rotation steps that are no longer required since we are working with rotated boxes when assume_straight_pages is False.

Any feedback is welcome!!

@charlesmindee charlesmindee added type: enhancement Improvement module: models Related to doctr.models framework: pytorch Related to PyTorch backend framework: tensorflow Related to TensorFlow backend labels Nov 19, 2021
@charlesmindee charlesmindee added this to the 0.5.0 milestone Nov 19, 2021
@charlesmindee charlesmindee self-assigned this Nov 19, 2021
@codecov
Copy link

codecov bot commented Nov 23, 2021

Codecov Report

Merging #641 (9b4aa76) into main (74ff9ff) will decrease coverage by 0.03%.
The diff coverage is 97.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #641      +/-   ##
==========================================
- Coverage   96.09%   96.06%   -0.04%     
==========================================
  Files         112      112              
  Lines        4357     4349       -8     
==========================================
- Hits         4187     4178       -9     
- Misses        170      171       +1     
Flag Coverage Δ
unittests 96.06% <97.91%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/models/detection/linknet/base.py 88.00% <90.90%> (ø)
doctr/models/detection/core.py 97.29% <100.00%> (-0.33%) ⬇️
...dels/detection/differentiable_binarization/base.py 91.92% <100.00%> (+0.10%) ⬆️
...s/detection/differentiable_binarization/pytorch.py 98.30% <100.00%> (ø)
...etection/differentiable_binarization/tensorflow.py 97.36% <100.00%> (ø)
doctr/models/detection/linknet/pytorch.py 96.26% <100.00%> (ø)
doctr/models/detection/linknet/tensorflow.py 96.51% <100.00%> (ø)
doctr/models/detection/predictor/pytorch.py 94.44% <100.00%> (ø)
doctr/models/detection/predictor/tensorflow.py 100.00% <100.00%> (ø)
doctr/models/predictor/base.py 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74ff9ff...9b4aa76. Read the comment docs.

Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot Charles 🙏 Looks good to me!

@fg-mindee fg-mindee added the type: breaking change Introducing a breaking change label Nov 23, 2021
@charlesmindee charlesmindee merged commit 95a81a1 into main Nov 23, 2021
@charlesmindee charlesmindee deleted the rotate_postprocessing branch November 23, 2021 15:34
@fg-mindee fg-mindee mentioned this pull request Nov 23, 2021
@fg-mindee fg-mindee added the ext: references Related to references folder label Dec 31, 2021
@fg-mindee fg-mindee added the ext: tests Related to tests folder label Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: references Related to references folder ext: tests Related to tests folder framework: pytorch Related to PyTorch backend framework: tensorflow Related to TensorFlow backend module: models Related to doctr.models type: breaking change Introducing a breaking change type: enhancement Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants