-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refacto: 🔧 postprocessing with rotated boxes #641
Conversation
Codecov Report
@@ Coverage Diff @@
## main #641 +/- ##
==========================================
- Coverage 96.09% 96.06% -0.04%
==========================================
Files 112 112
Lines 4357 4349 -8
==========================================
- Hits 4187 4178 -9
- Misses 170 171 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot Charles 🙏 Looks good to me!
Following #632 and #551, this PR removes deprecated flags and deprecated page-rotation steps that are no longer required since we are working with rotated boxes when
assume_straight_pages
isFalse
.Any feedback is welcome!!