Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Fixed isort and typing checks #643

Merged
merged 3 commits into from
Nov 22, 2021
Merged

style: Fixed isort and typing checks #643

merged 3 commits into from
Nov 22, 2021

Conversation

fg-mindee
Copy link
Contributor

This PR introduces the following modifications:

  • fixes typing due to the latest rapidfuzz release
  • fixes the import order
  • ensures the isort CI check fails when files are modified

Any feedback is welcome!

@fg-mindee fg-mindee added type: enhancement Improvement topic: ci Related to CI labels Nov 22, 2021
@fg-mindee fg-mindee added this to the 0.5.0 milestone Nov 22, 2021
@fg-mindee fg-mindee self-assigned this Nov 22, 2021
@codecov
Copy link

codecov bot commented Nov 22, 2021

Codecov Report

Merging #643 (85d3a19) into main (0aa4bb1) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #643      +/-   ##
==========================================
- Coverage   96.09%   96.07%   -0.03%     
==========================================
  Files         112      112              
  Lines        4357     4357              
==========================================
- Hits         4187     4186       -1     
- Misses        170      171       +1     
Flag Coverage Δ
unittests 96.07% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/models/recognition/utils.py 100.00% <100.00%> (ø)
...dels/detection/differentiable_binarization/base.py 91.19% <0.00%> (-0.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0aa4bb1...85d3a19. Read the comment docs.

Copy link
Collaborator

@charlesmindee charlesmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fg-mindee fg-mindee merged commit acb0c79 into main Nov 22, 2021
@fg-mindee fg-mindee deleted the style-fix branch November 22, 2021 16:36
@fg-mindee fg-mindee added the type: code quality Related to code quality label Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: ci Related to CI type: code quality Related to code quality type: enhancement Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants