Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 assume_straight_pages in predictor #647

Merged
merged 1 commit into from
Nov 24, 2021
Merged

Conversation

charlesmindee
Copy link
Collaborator

This PR fixes the issue #646.
The detection predictor should receive the assume_straight_boxes flag when instantiated.

Any feedback is welcome!

@charlesmindee charlesmindee self-assigned this Nov 24, 2021
@charlesmindee charlesmindee added this to the 0.5.0 milestone Nov 24, 2021
@charlesmindee charlesmindee added type: bug Something isn't working critical High priority module: models Related to doctr.models labels Nov 24, 2021
@codecov
Copy link

codecov bot commented Nov 24, 2021

Codecov Report

Merging #647 (6875aaf) into main (95a81a1) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #647   +/-   ##
=======================================
  Coverage   96.06%   96.06%           
=======================================
  Files         112      112           
  Lines        4349     4349           
=======================================
  Hits         4178     4178           
  Misses        171      171           
Flag Coverage Δ
unittests 96.06% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/models/detection/zoo.py 100.00% <100.00%> (ø)
doctr/models/zoo.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95a81a1...6875aaf. Read the comment docs.

Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@charlesmindee charlesmindee merged commit 1ade8c4 into main Nov 24, 2021
@charlesmindee charlesmindee deleted the bug_predictor branch November 24, 2021 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
critical High priority module: models Related to doctr.models type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants