Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added rbox_iou function with a memory-savy option #659

Merged
merged 6 commits into from
Nov 30, 2021
Merged

Conversation

fg-mindee
Copy link
Contributor

This PR introduces the following modifications:

  • adds rbox_iou function to compute IoU between sets of rotated bounding boxes
  • replace iou computation in task metrics with rbox_iou while adding a use_broadcasting boolean flag
  • adds missing constructor arg description in docstrings
  • fixes typos in multiple docstrings

Any feedback is welcome!

@fg-mindee fg-mindee added type: enhancement Improvement module: utils Related to doctr.utils labels Nov 29, 2021
@fg-mindee fg-mindee added this to the 0.5.0 milestone Nov 29, 2021
@fg-mindee fg-mindee self-assigned this Nov 29, 2021
@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #659 (5c979f6) into main (1937843) will increase coverage by 0.04%.
The diff coverage is 89.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #659      +/-   ##
==========================================
+ Coverage   96.07%   96.12%   +0.04%     
==========================================
  Files         113      113              
  Lines        4386     4410      +24     
==========================================
+ Hits         4214     4239      +25     
+ Misses        172      171       -1     
Flag Coverage Δ
unittests 96.12% <89.74%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/utils/metrics.py 97.40% <89.74%> (+1.26%) ⬆️
...dels/detection/differentiable_binarization/base.py 91.30% <0.00%> (-0.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1937843...5c979f6. Read the comment docs.

Copy link
Collaborator

@charlesmindee charlesmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fg-mindee fg-mindee merged commit 113ec60 into main Nov 30, 2021
@fg-mindee fg-mindee deleted the flex-metric branch November 30, 2021 11:07
@fg-mindee fg-mindee added the ext: tests Related to tests folder label Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: tests Related to tests folder module: utils Related to doctr.utils type: enhancement Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants