Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] SROIE dataset #660

Merged
merged 29 commits into from
Dec 7, 2021
Merged

[refactor] SROIE dataset #660

merged 29 commits into from
Dec 7, 2021

Conversation

felixdittrich92
Copy link
Contributor

This PR refactors the SROIE implementation and enables also rotated boxes

@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #660 (16e40a3) into main (8382896) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #660      +/-   ##
==========================================
+ Coverage   96.28%   96.34%   +0.06%     
==========================================
  Files         117      117              
  Lines        4523     4519       -4     
==========================================
- Hits         4355     4354       -1     
+ Misses        168      165       -3     
Flag Coverage Δ
unittests 96.34% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/datasets/sroie.py 97.14% <100.00%> (+2.27%) ⬆️
doctr/models/builder.py 98.21% <0.00%> (+1.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8382896...16e40a3. Read the comment docs.

@fg-mindee fg-mindee added type: enhancement Improvement module: datasets Related to doctr.datasets labels Nov 30, 2021
Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the refactor, I added some comments 👍

doctr/datasets/sroie.py Outdated Show resolved Hide resolved
doctr/datasets/sroie.py Outdated Show resolved Hide resolved
Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks!

@fg-mindee fg-mindee self-assigned this Dec 7, 2021
@fg-mindee fg-mindee added this to the 0.6.0 milestone Dec 7, 2021
@fg-mindee fg-mindee merged commit e076418 into mindee:main Dec 7, 2021
@felixdittrich92 felixdittrich92 deleted the refa-sroie branch December 7, 2021 14:36
@fg-mindee fg-mindee added ext: docs Related to docs folder ext: tests Related to tests folder type: new feature New feature type: enhancement Improvement and removed type: enhancement Improvement type: new feature New feature labels Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: docs Related to docs folder ext: tests Related to tests folder module: datasets Related to doctr.datasets type: enhancement Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants