fix: box angle rectification according to the quadrant #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlesmindee
added
type: bug
|
@charlesmindee there is still a failing job for the analysis script :/ |
|
Yes I need to debug everything, I'll tell you when it's ready! |
Codecov Report
@@ Coverage Diff @@
## main #667 +/- ##
==========================================
- Coverage 96.35% 96.25% -0.10%
==========================================
Files 117 117
Lines 4466 4485 +19
==========================================
+ Hits 4303 4317 +14
- Misses 163 168 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
It should be OK! |
fg-mindee
reviewed
Dec 2, 2021
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides an heuristic to determine the quadrant of the document (only 2 quadrants are allowed, +90 and -90 with respect to the horizontal). The quadrant is determined with the median aspect ratio of cv2 min area rect, and then we can rectify boxes knowing the quadrant.
This is not a long-term fix, we should add a classifier to resolve the angle of each box perfectly, but for the moment I couldn't find anything else to fix this issue.
Any feedback is welcome!