Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added file existence check in DetectionDataset #672

Merged
merged 4 commits into from
Dec 2, 2021
Merged

Conversation

fg-mindee
Copy link
Contributor

This PR introduces the following modifications:

  • adds the file existence check in doctr.datasets.DetectionDataset
  • refactors RecognitionDataset constructor
  • adds unittest for file existence check

Any feedback is welcome!

@fg-mindee fg-mindee added type: enhancement Improvement ext: tests Related to tests folder module: datasets Related to doctr.datasets topic: text detection Related to the task of text detection labels Dec 2, 2021
@fg-mindee fg-mindee added this to the 0.5.0 milestone Dec 2, 2021
@fg-mindee fg-mindee self-assigned this Dec 2, 2021
@codecov
Copy link

codecov bot commented Dec 2, 2021

Codecov Report

Merging #672 (03414c8) into main (1dad108) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #672      +/-   ##
==========================================
+ Coverage   96.17%   96.24%   +0.06%     
==========================================
  Files         117      117              
  Lines        4472     4471       -1     
==========================================
+ Hits         4301     4303       +2     
+ Misses        171      168       -3     
Flag Coverage Δ
unittests 96.24% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/datasets/cord.py 97.43% <ø> (ø)
doctr/datasets/doc_artefacts.py 94.11% <ø> (ø)
doctr/datasets/funsd.py 96.87% <ø> (ø)
doctr/datasets/sroie.py 94.87% <ø> (ø)
doctr/datasets/detection.py 97.05% <100.00%> (+0.18%) ⬆️
doctr/datasets/recognition.py 81.81% <100.00%> (+5.81%) ⬆️
doctr/datasets/ocr.py 92.00% <0.00%> (+4.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dad108...03414c8. Read the comment docs.

Copy link
Collaborator

@charlesmindee charlesmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fg-mindee fg-mindee merged commit 8eb89e8 into main Dec 2, 2021
@fg-mindee fg-mindee deleted the ds-check branch December 2, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: tests Related to tests folder module: datasets Related to doctr.datasets topic: text detection Related to the task of text detection type: enhancement Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants