-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pymupdf version #673
fix: pymupdf version #673
Conversation
Codecov Report
@@ Coverage Diff @@
## main #673 +/- ##
==========================================
+ Coverage 96.17% 96.32% +0.15%
==========================================
Files 117 117
Lines 4472 4466 -6
==========================================
+ Hits 4301 4302 +1
+ Misses 171 164 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before changing this, we need to ensure that version 1.18.11 is compatible. Because here enlarging the constraint will always install (in the CI) the latest, meaning 1.18.15. Can you confirm that you can run all unittests in 1.18.11
? 🙏
It is indeed not working with 1.18.11, it works since the 1.18.13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect thanks! Two things:
- let's do the same type of check when we want to update some dependency specifiers
- if you have a clear idea of the justification of the upper & lower bounds of the specifier, could you add an inline comment in the
setup.py
? (that will be easier for next time)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect thanks!
This PR allows the PyMuPDF version to be 1.18.15 for in-house compatibility issues.
Any feedback is welcome!