Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pymupdf version #673

Merged
merged 5 commits into from
Dec 3, 2021
Merged

fix: pymupdf version #673

merged 5 commits into from
Dec 3, 2021

Conversation

charlesmindee
Copy link
Collaborator

This PR allows the PyMuPDF version to be 1.18.15 for in-house compatibility issues.

Any feedback is welcome!

@codecov
Copy link

codecov bot commented Dec 2, 2021

Codecov Report

Merging #673 (f1f0b0b) into main (1dad108) will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #673      +/-   ##
==========================================
+ Coverage   96.17%   96.32%   +0.15%     
==========================================
  Files         117      117              
  Lines        4472     4466       -6     
==========================================
+ Hits         4301     4302       +1     
+ Misses        171      164       -7     
Flag Coverage Δ
unittests 96.32% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...dels/detection/differentiable_binarization/base.py 91.30% <0.00%> (-0.63%) ⬇️
doctr/datasets/cord.py 97.43% <0.00%> (ø)
doctr/datasets/funsd.py 96.87% <0.00%> (ø)
doctr/datasets/sroie.py 94.87% <0.00%> (ø)
doctr/datasets/doc_artefacts.py 94.11% <0.00%> (ø)
doctr/datasets/detection.py 97.05% <0.00%> (+0.18%) ⬆️
doctr/models/detection/linknet/base.py 89.02% <0.00%> (+1.02%) ⬆️
doctr/models/detection/linknet/pytorch.py 98.03% <0.00%> (+1.77%) ⬆️
doctr/models/detection/linknet/tensorflow.py 100.00% <0.00%> (+3.48%) ⬆️
doctr/datasets/ocr.py 92.00% <0.00%> (+4.00%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dad108...f1f0b0b. Read the comment docs.

@fg-mindee fg-mindee self-assigned this Dec 2, 2021
@fg-mindee fg-mindee added the topic: build Related to dependencies and build label Dec 2, 2021
@fg-mindee fg-mindee added this to the 0.5.0 milestone Dec 2, 2021
@fg-mindee fg-mindee self-requested a review December 2, 2021 16:22
Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before changing this, we need to ensure that version 1.18.11 is compatible. Because here enlarging the constraint will always install (in the CI) the latest, meaning 1.18.15. Can you confirm that you can run all unittests in 1.18.11? 🙏

@charlesmindee
Copy link
Collaborator Author

It is indeed not working with 1.18.11, it works since the 1.18.13

fg-mindee
fg-mindee previously approved these changes Dec 3, 2021
Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect thanks! Two things:

  • let's do the same type of check when we want to update some dependency specifiers
  • if you have a clear idea of the justification of the upper & lower bounds of the specifier, could you add an inline comment in the setup.py? (that will be easier for next time)

Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect thanks!

@charlesmindee charlesmindee merged commit 4e4ed81 into main Dec 3, 2021
@charlesmindee charlesmindee deleted the fitz branch December 3, 2021 14:34
@fg-mindee fg-mindee added the type: enhancement Improvement label Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: build Related to dependencies and build type: enhancement Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants