Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add line resolution for rotated boxes #677

Merged
merged 1 commit into from
Dec 7, 2021
Merged

feat: add line resolution for rotated boxes #677

merged 1 commit into from
Dec 7, 2021

Conversation

charlesmindee
Copy link
Collaborator

This PR improves the line resolution heuristic: when we build a document with rotated boxes, lines are resolved the right way (with a rotation of the page).

Any feedback is welcome!

@charlesmindee charlesmindee added type: enhancement Improvement module: models Related to doctr.models labels Dec 7, 2021
@charlesmindee charlesmindee self-assigned this Dec 7, 2021
@charlesmindee charlesmindee added this to the 0.5.0 milestone Dec 7, 2021
Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I added some comment, I think we need to ensure this is compatible with #488 and to fix the failing CI job 👍

doctr/models/builder.py Show resolved Hide resolved
@fg-mindee fg-mindee linked an issue Dec 7, 2021 that may be closed by this pull request
Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small question in comment

doctr/models/builder.py Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Dec 7, 2021

Codecov Report

Merging #677 (8f524ce) into main (8382896) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #677   +/-   ##
=======================================
  Coverage   96.28%   96.28%           
=======================================
  Files         117      117           
  Lines        4523     4525    +2     
=======================================
+ Hits         4355     4357    +2     
  Misses        168      168           
Flag Coverage Δ
unittests 96.28% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/models/builder.py 96.49% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8382896...8f524ce. Read the comment docs.

Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification!

@charlesmindee charlesmindee merged commit 30d1b83 into main Dec 7, 2021
@charlesmindee charlesmindee deleted the rlines branch December 7, 2021 14:54
@fg-mindee fg-mindee added the ext: tests Related to tests folder label Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: tests Related to tests folder module: models Related to doctr.models type: enhancement Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve lines when rotation is enabled
2 participants