-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add line resolution for rotated boxes #677
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I added some comment, I think we need to ensure this is compatible with #488 and to fix the failing CI job 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small question in comment
Codecov Report
@@ Coverage Diff @@
## main #677 +/- ##
=======================================
Coverage 96.28% 96.28%
=======================================
Files 117 117
Lines 4523 4525 +2
=======================================
+ Hits 4355 4357 +2
Misses 168 168
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification!
This PR improves the line resolution heuristic: when we build a document with rotated boxes, lines are resolved the right way (with a rotation of the page).
Any feedback is welcome!