-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add rboxes rectification in Linknet postprocessing #679
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Would you mind adding a small docstring for this method on both the DBNet & LinkNet to explain a bit the usage of those new args please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small typos to fix 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cheers 🙏
Codecov Report
@@ Coverage Diff @@
## main #679 +/- ##
==========================================
+ Coverage 96.28% 96.29% +0.01%
==========================================
Files 117 117
Lines 4523 4538 +15
==========================================
+ Hits 4355 4370 +15
Misses 168 168
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This PR is an update of the linknet postprocessor, so that it is similar to the DB.
Any feedback is welcome!