Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rboxes rectification in Linknet postprocessing #679

Merged
merged 3 commits into from
Dec 7, 2021

Conversation

charlesmindee
Copy link
Collaborator

This PR is an update of the linknet postprocessor, so that it is similar to the DB.

Any feedback is welcome!

@charlesmindee charlesmindee added type: enhancement Improvement module: models Related to doctr.models labels Dec 7, 2021
@charlesmindee charlesmindee added this to the 0.5.0 milestone Dec 7, 2021
@charlesmindee charlesmindee self-assigned this Dec 7, 2021
Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Would you mind adding a small docstring for this method on both the DBNet & LinkNet to explain a bit the usage of those new args please?

Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typos to fix 🙏

doctr/models/detection/differentiable_binarization/base.py Outdated Show resolved Hide resolved
doctr/models/detection/linknet/base.py Outdated Show resolved Hide resolved
Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers 🙏

@codecov
Copy link

codecov bot commented Dec 7, 2021

Codecov Report

Merging #679 (2d52e46) into main (8382896) will increase coverage by 0.01%.
The diff coverage is 68.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #679      +/-   ##
==========================================
+ Coverage   96.28%   96.29%   +0.01%     
==========================================
  Files         117      117              
  Lines        4523     4538      +15     
==========================================
+ Hits         4355     4370      +15     
  Misses        168      168              
Flag Coverage Δ
unittests 96.29% <68.42%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...dels/detection/differentiable_binarization/base.py 92.77% <ø> (+2.77%) ⬆️
doctr/models/detection/linknet/base.py 85.14% <68.42%> (-3.88%) ⬇️
doctr/utils/geometry.py 98.00% <0.00%> (ø)
doctr/datasets/sroie.py 97.14% <0.00%> (+2.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8382896...2d52e46. Read the comment docs.

@charlesmindee charlesmindee merged commit 1671cdd into main Dec 7, 2021
@charlesmindee charlesmindee deleted the linknet_rboxes branch December 7, 2021 15:31
@fg-mindee fg-mindee added the topic: text detection Related to the task of text detection label Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: models Related to doctr.models topic: text detection Related to the task of text detection type: enhancement Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants