-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fixed MASTER recognition architecture #687
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Actually, the paper references the ResNet31 architecture which has 256 channels in stage 2, but in the MASTER paper (Table1) they modified the stage 2 to have 512 channels. So I reverted back those changes and added back the URL & benchmark perf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the revert
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Codecov Report
@@ Coverage Diff @@
## main #687 +/- ##
==========================================
- Coverage 96.40% 96.07% -0.34%
==========================================
Files 117 120 +3
Lines 4540 4589 +49
==========================================
+ Hits 4377 4409 +32
- Misses 163 180 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This PR introduces the following modifications:
magc_resnet31
backbone added to available backbones, and addspretrained_backbone
optionAny feedback is welcome!