Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed param override of backbone #689

Merged
merged 1 commit into from
Dec 9, 2021
Merged

fix: Fixed param override of backbone #689

merged 1 commit into from
Dec 9, 2021

Conversation

fg-mindee
Copy link
Contributor

This PR fixes the initialization when the feature extractor already has defined param values. Before this PR, those values were overridden with a param initialization, and this PR prevents this (for pretrained_backbone=True to work correctly).

cf. #591

Any feedback is welcome!

@fg-mindee fg-mindee added type: bug Something isn't working module: models Related to doctr.models framework: pytorch Related to PyTorch backend topic: text detection Related to the task of text detection topic: text recognition Related to the task of text recognition labels Dec 9, 2021
@fg-mindee fg-mindee added this to the 0.5.0 milestone Dec 9, 2021
@fg-mindee fg-mindee self-assigned this Dec 9, 2021
Copy link
Collaborator

@charlesmindee charlesmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov
Copy link

codecov bot commented Dec 9, 2021

Codecov Report

Merging #689 (206353f) into main (9c45ba6) will decrease coverage by 0.41%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #689      +/-   ##
==========================================
- Coverage   96.40%   95.99%   -0.42%     
==========================================
  Files         117      117              
  Lines        4540     4548       +8     
==========================================
- Hits         4377     4366      -11     
- Misses        163      182      +19     
Flag Coverage Δ
unittests 95.99% <100.00%> (-0.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/detection/differentiable_binarization/pytorch.py 97.50% <100.00%> (-0.81%) ⬇️
doctr/models/detection/linknet/pytorch.py 98.07% <100.00%> (+0.03%) ⬆️
doctr/models/recognition/crnn/pytorch.py 94.18% <100.00%> (-5.82%) ⬇️
doctr/models/recognition/master/pytorch.py 93.47% <100.00%> (-2.11%) ⬇️
...dels/detection/differentiable_binarization/base.py 90.00% <0.00%> (-2.78%) ⬇️
doctr/models/builder.py 96.49% <0.00%> (-2.64%) ⬇️
doctr/models/detection/linknet/base.py 85.14% <0.00%> (-1.99%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c45ba6...206353f. Read the comment docs.

@fg-mindee fg-mindee merged commit 050faf1 into main Dec 9, 2021
@fg-mindee fg-mindee deleted the pretrained-fix branch December 9, 2021 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework: pytorch Related to PyTorch backend module: models Related to doctr.models topic: text detection Related to the task of text detection topic: text recognition Related to the task of text recognition type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants