Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed deprecation warnings from numpy & PyMuPDF #692

Merged
merged 3 commits into from
Dec 10, 2021
Merged

Conversation

fg-mindee
Copy link
Contributor

This PR fixes the multiple deprecation warnings from PyMuPDF & numpy by using the recommended replacement.

Any feedback is welcome!

@fg-mindee fg-mindee added type: enhancement Improvement module: models Related to doctr.models module: io Related to doctr.io module: datasets Related to doctr.datasets labels Dec 10, 2021
@fg-mindee fg-mindee added this to the 0.5.0 milestone Dec 10, 2021
@fg-mindee fg-mindee self-assigned this Dec 10, 2021
@fg-mindee fg-mindee added ext: tests Related to tests folder module: utils Related to doctr.utils labels Dec 10, 2021
Copy link
Collaborator

@charlesmindee charlesmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov
Copy link

codecov bot commented Dec 10, 2021

Codecov Report

Merging #692 (6d3263b) into main (050faf1) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #692      +/-   ##
==========================================
+ Coverage   95.99%   96.08%   +0.08%     
==========================================
  Files         117      117              
  Lines        4548     4548              
==========================================
+ Hits         4366     4370       +4     
+ Misses        182      178       -4     
Flag Coverage Δ
unittests 96.08% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/datasets/doc_artefacts.py 94.11% <100.00%> (ø)
doctr/io/pdf.py 100.00% <100.00%> (ø)
doctr/models/_utils.py 95.34% <100.00%> (ø)
doctr/utils/metrics.py 97.40% <100.00%> (ø)
doctr/models/detection/linknet/base.py 85.14% <0.00%> (+1.98%) ⬆️
doctr/models/recognition/predictor/pytorch.py 96.96% <0.00%> (+6.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 050faf1...6d3263b. Read the comment docs.

@fg-mindee fg-mindee merged commit 91342df into main Dec 10, 2021
@fg-mindee fg-mindee deleted the warning-fix branch December 10, 2021 09:45
@fg-mindee fg-mindee added the type: code quality Related to code quality label Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: tests Related to tests folder module: datasets Related to doctr.datasets module: io Related to doctr.io module: models Related to doctr.models module: utils Related to doctr.utils type: code quality Related to code quality type: enhancement Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants