-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added plot_samples support to visualize the images along with the targets #704
Conversation
When the script is run, I am facing the following error:
I am also unable to understand why out images.shape == (1024, 1024, 3) instead of (1024, 800, 3) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Let's remove the files that aren't related to the PR description :)
Codecov Report
@@ Coverage Diff @@
## main #704 +/- ##
==========================================
+ Coverage 96.12% 96.17% +0.04%
==========================================
Files 124 124
Lines 4648 4648
==========================================
+ Hits 4468 4470 +2
+ Misses 180 178 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few other things as well in comment
references/obj_detection/utils.py
Outdated
_, axes = plt.subplots(1, nb_samples, figsize=(20, 5)) | ||
for idx in range(nb_samples): | ||
img = (255 * images[idx].numpy()).round().clip(0, 255).astype(np.uint8) | ||
target = img.copy() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's move this after the dimension transpose
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Would you mind increasing the line width of the box? It's barely visible when I try on my end 😅 (and perhaps add a screenshot of how it renders in the PR description for future references 👍 )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
This PR introduces the following modifications:
Any feedback is welcome :)