-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added checkpoint for obj_detection #713
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Would you mind modifying the unittest https://github.com/mindee/doctr/blob/main/tests/pytorch/test_models_obj_detection_pt.py
with:
- reducing the input size to (512, 512) to ease the RAM
- before line 15, recreate the model by passing
pretrained=True
to ensure the checkpoint can be downloaded
Thanks. I have made the changes . |
Codecov Report
@@ Coverage Diff @@
## main #713 +/- ##
==========================================
+ Coverage 96.23% 96.32% +0.08%
==========================================
Files 125 125
Lines 4707 4707
==========================================
+ Hits 4530 4534 +4
+ Misses 177 173 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last suggestion to check both cases (especially for faster, pretrained=True does change a lot the initialization of the model)
Thanks for all the suggestions :) Implemented them all |
I think it had passed the unittest for object detection. It should not be a problem right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, the CI is having timeouts on datasets unittests, but that will be fixed by another PR quite soon anyway!
Thanks for the information :) |
This PR adds a checkpoint for artefact detection.
Any feedback is welcome:)