Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fixed TF loss unittest #725

Merged
merged 1 commit into from
Dec 17, 2021
Merged

test: Fixed TF loss unittest #725

merged 1 commit into from
Dec 17, 2021

Conversation

fg-mindee
Copy link
Contributor

This PR fixes the tolerance threshold for the loss difference between straight & rotated bboxes

Any feedback is welcome!

@fg-mindee fg-mindee added module: models Related to doctr.models ext: tests Related to tests folder framework: tensorflow Related to TensorFlow backend topic: object detection Related to the task of object detection labels Dec 16, 2021
@fg-mindee fg-mindee added this to the 0.5.0 milestone Dec 16, 2021
@fg-mindee fg-mindee self-assigned this Dec 16, 2021
@codecov
Copy link

codecov bot commented Dec 16, 2021

Codecov Report

Merging #725 (b9cc876) into main (c32c1ed) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #725      +/-   ##
==========================================
- Coverage   96.23%   96.19%   -0.05%     
==========================================
  Files         125      125              
  Lines        4707     4707              
==========================================
- Hits         4530     4528       -2     
- Misses        177      179       +2     
Flag Coverage Δ
unittests 96.19% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...dels/detection/differentiable_binarization/base.py 91.66% <0.00%> (-2.23%) ⬇️
doctr/models/detection/linknet/base.py 89.10% <0.00%> (+1.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c32c1ed...b9cc876. Read the comment docs.

Copy link
Collaborator

@charlesmindee charlesmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fg-mindee fg-mindee merged commit 5bd4ff0 into main Dec 17, 2021
@fg-mindee fg-mindee deleted the detection-fix branch December 17, 2021 12:20
@fg-mindee fg-mindee added type: bug Something isn't working and removed module: models Related to doctr.models labels Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: tests Related to tests folder framework: tensorflow Related to TensorFlow backend topic: object detection Related to the task of object detection type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants