Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added inference+post processing script for artefact detection #728

Merged
merged 8 commits into from
Dec 23, 2021

Conversation

SiddhantBahuguna
Copy link
Contributor

@SiddhantBahuguna SiddhantBahuguna commented Dec 18, 2021

This PR introduces the following :

-> It adds a bare evaluation script without post nms and post processing.
Any feedback is welcome :)

@SiddhantBahuguna SiddhantBahuguna added ext: scripts Related to scripts folder topic: object detection Related to the task of object detection labels Dec 18, 2021
@SiddhantBahuguna SiddhantBahuguna self-assigned this Dec 18, 2021
@SiddhantBahuguna SiddhantBahuguna added this to the 0.5.0 milestone Dec 18, 2021
@codecov
Copy link

codecov bot commented Dec 21, 2021

Codecov Report

Merging #728 (878bc83) into main (caa363c) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #728      +/-   ##
==========================================
- Coverage   96.04%   96.01%   -0.04%     
==========================================
  Files         129      129              
  Lines        4806     4794      -12     
==========================================
- Hits         4616     4603      -13     
- Misses        190      191       +1     
Flag Coverage Δ
unittests 96.01% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/models/detection/predictor/tensorflow.py 94.44% <0.00%> (-5.56%) ⬇️
doctr/io/pdf.py 98.33% <0.00%> (-1.67%) ⬇️
doctr/models/detection/linknet/pytorch.py 97.82% <0.00%> (-0.26%) ⬇️
doctr/models/recognition/predictor/tensorflow.py 91.17% <0.00%> (ø)
doctr/models/builder.py 97.36% <0.00%> (+0.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caa363c...878bc83. Read the comment docs.

Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments!

scripts/detect_artefacts.py Outdated Show resolved Hide resolved
scripts/detect_artefacts.py Outdated Show resolved Hide resolved
scripts/detect_artefacts.py Outdated Show resolved Hide resolved
scripts/detect_artefacts.py Outdated Show resolved Hide resolved
scripts/detect_artefacts.py Outdated Show resolved Hide resolved
scripts/detect_artefacts.py Outdated Show resolved Hide resolved
scripts/detect_artefacts.py Show resolved Hide resolved
scripts/detect_artefacts.py Outdated Show resolved Hide resolved
scripts/detect_artefacts.py Outdated Show resolved Hide resolved
scripts/detect_artefacts.py Outdated Show resolved Hide resolved
scripts/detect_artefacts.py Outdated Show resolved Hide resolved
scripts/detect_artefacts.py Outdated Show resolved Hide resolved
scripts/detect_artefacts.py Outdated Show resolved Hide resolved
scripts/detect_artefacts.py Outdated Show resolved Hide resolved
scripts/detect_artefacts.py Show resolved Hide resolved
Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still some things to handle

scripts/detect_artefacts.py Outdated Show resolved Hide resolved
scripts/detect_artefacts.py Outdated Show resolved Hide resolved
scripts/detect_artefacts.py Outdated Show resolved Hide resolved
scripts/detect_artefacts.py Outdated Show resolved Hide resolved
scripts/detect_artefacts.py Outdated Show resolved Hide resolved
scripts/detect_artefacts.py Show resolved Hide resolved
scripts/detect_artefacts.py Outdated Show resolved Hide resolved
scripts/detect_artefacts.py Outdated Show resolved Hide resolved
scripts/detect_artefacts.py Outdated Show resolved Hide resolved
@SiddhantBahuguna SiddhantBahuguna marked this pull request as ready for review December 23, 2021 08:45
Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@SiddhantBahuguna SiddhantBahuguna merged commit e5eb963 into main Dec 23, 2021
@SiddhantBahuguna SiddhantBahuguna deleted the arte_inference branch December 23, 2021 11:43
@fg-mindee fg-mindee added type: new feature New feature framework: pytorch Related to PyTorch backend labels Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: scripts Related to scripts folder framework: pytorch Related to PyTorch backend topic: object detection Related to the task of object detection type: new feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants