Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Silenced PyMuPDF warnings #740

Merged
merged 1 commit into from
Dec 23, 2021
Merged

test: Silenced PyMuPDF warnings #740

merged 1 commit into from
Dec 23, 2021

Conversation

fg-mindee
Copy link
Contributor

This PR silences the deprecation warnings from PyMuPDF.

Any feedback is welcome!

@fg-mindee fg-mindee added type: enhancement Improvement ext: tests Related to tests folder labels Dec 23, 2021
@fg-mindee fg-mindee added this to the 0.5.0 milestone Dec 23, 2021
@fg-mindee fg-mindee self-assigned this Dec 23, 2021
@codecov
Copy link

codecov bot commented Dec 23, 2021

Codecov Report

Merging #740 (688b5dc) into main (808081f) will increase coverage by 0.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #740      +/-   ##
==========================================
+ Coverage   96.05%   96.24%   +0.18%     
==========================================
  Files         129      129              
  Lines        4794     4794              
==========================================
+ Hits         4605     4614       +9     
+ Misses        189      180       -9     
Flag Coverage Δ
unittests 96.24% <100.00%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/datasets/loader.py 100.00% <100.00%> (ø)
doctr/models/builder.py 99.12% <0.00%> (+2.63%) ⬆️
doctr/models/detection/linknet/base.py 91.08% <0.00%> (+3.96%) ⬆️
doctr/models/recognition/predictor/tensorflow.py 97.05% <0.00%> (+5.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcaf0a3...688b5dc. Read the comment docs.

Copy link
Collaborator

@charlesmindee charlesmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@fg-mindee fg-mindee merged commit a1291f0 into main Dec 23, 2021
@fg-mindee fg-mindee deleted the fitz-warnings branch December 23, 2021 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: tests Related to tests folder type: enhancement Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants