Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Unified return_preds flags across all tasks #741

Merged
merged 3 commits into from
Dec 23, 2021
Merged

Conversation

fg-mindee
Copy link
Contributor

This PR introduces the following modifications:

  • ensures all prediction call flags are named the same way ("return_boxes" --> "return_preds")
  • reflected changes on unittests, and demo

Any feedback is welcome!

@fg-mindee fg-mindee added module: models Related to doctr.models ext: tests Related to tests folder type: breaking change Introducing a breaking change ext: api Related to api folder topic: object detection Related to the task of object detection labels Dec 23, 2021
@fg-mindee fg-mindee added this to the 0.5.0 milestone Dec 23, 2021
@fg-mindee fg-mindee self-assigned this Dec 23, 2021
@codecov
Copy link

codecov bot commented Dec 23, 2021

Codecov Report

Merging #741 (fbda1ac) into main (808081f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #741   +/-   ##
=======================================
  Coverage   96.05%   96.05%           
=======================================
  Files         129      129           
  Lines        4794     4794           
=======================================
  Hits         4605     4605           
  Misses        189      189           
Flag Coverage Δ
unittests 96.05% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/models/detection/predictor/pytorch.py 94.44% <ø> (ø)
doctr/models/detection/predictor/tensorflow.py 94.44% <ø> (ø)
doctr/datasets/loader.py 100.00% <100.00%> (ø)
...s/detection/differentiable_binarization/pytorch.py 98.37% <100.00%> (ø)
...etection/differentiable_binarization/tensorflow.py 97.36% <100.00%> (ø)
doctr/models/detection/linknet/pytorch.py 97.82% <100.00%> (ø)
doctr/models/detection/linknet/tensorflow.py 100.00% <100.00%> (ø)
doctr/models/_utils.py 95.60% <0.00%> (-3.30%) ⬇️
doctr/models/builder.py 97.36% <0.00%> (+0.87%) ⬆️
doctr/models/recognition/predictor/tensorflow.py 97.05% <0.00%> (+5.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcaf0a3...fbda1ac. Read the comment docs.

Copy link
Collaborator

@charlesmindee charlesmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fg-mindee fg-mindee merged commit 94eeb41 into main Dec 23, 2021
@fg-mindee fg-mindee deleted the det-arg branch December 23, 2021 15:40
@fg-mindee fg-mindee added the type: enhancement Improvement label Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: api Related to api folder ext: tests Related to tests folder module: models Related to doctr.models topic: object detection Related to the task of object detection type: breaking change Introducing a breaking change type: enhancement Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants