Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed mask computation of DBNet #753

Merged
merged 1 commit into from
Dec 26, 2021
Merged

fix: Fixed mask computation of DBNet #753

merged 1 commit into from
Dec 26, 2021

Conversation

fg-mindee
Copy link
Contributor

This PR simply fixes the segmentation mask building: I believe we have never entered that loop, because considering its shape, it's impossible that it would have worked.

Any feedback is welcome!

@fg-mindee fg-mindee added type: bug Something isn't working module: models Related to doctr.models topic: text detection Related to the task of text detection labels Dec 24, 2021
@fg-mindee fg-mindee added this to the 0.5.0 milestone Dec 24, 2021
@fg-mindee fg-mindee self-assigned this Dec 24, 2021
@codecov
Copy link

codecov bot commented Dec 25, 2021

Codecov Report

Merging #753 (d297906) into main (45e1647) will decrease coverage by 0.20%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #753      +/-   ##
==========================================
- Coverage   96.20%   95.99%   -0.21%     
==========================================
  Files         129      129              
  Lines        4799     4799              
==========================================
- Hits         4617     4607      -10     
- Misses        182      192      +10     
Flag Coverage Δ
unittests 95.99% <0.00%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...dels/detection/differentiable_binarization/base.py 90.76% <0.00%> (ø)
doctr/models/recognition/predictor/tensorflow.py 91.17% <0.00%> (-5.89%) ⬇️
doctr/models/_utils.py 94.50% <0.00%> (-4.40%) ⬇️
doctr/models/builder.py 96.49% <0.00%> (-2.64%) ⬇️
doctr/transforms/modules/base.py 94.44% <0.00%> (-1.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45e1647...d297906. Read the comment docs.

Copy link
Collaborator

@charlesmindee charlesmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that fix!

@fg-mindee fg-mindee merged commit 807a392 into main Dec 26, 2021
@fg-mindee fg-mindee deleted the db-fix branch December 26, 2021 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: models Related to doctr.models topic: text detection Related to the task of text detection type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants