Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Removed contiguous param since it's included in torch>=1.7 #756

Merged
merged 4 commits into from
Dec 26, 2021

Conversation

fg-mindee
Copy link
Contributor

This PR introduces the following modifications:

  • removes the Pytorch to force params in a contiguous chunk to speed up optimization (now it's included in the core library)
  • updates the CI & documentation accordingly
  • removes unneeded loader operations in training scripts

Any feedback is welcome!

@fg-mindee fg-mindee added topic: ci Related to CI ext: references Related to references folder framework: pytorch Related to PyTorch backend labels Dec 26, 2021
@fg-mindee fg-mindee added this to the 0.5.0 milestone Dec 26, 2021
@fg-mindee fg-mindee self-assigned this Dec 26, 2021
@codecov
Copy link

codecov bot commented Dec 26, 2021

Codecov Report

Merging #756 (3f3ffce) into main (45e1647) will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #756      +/-   ##
==========================================
- Coverage   96.20%   96.12%   -0.09%     
==========================================
  Files         129      129              
  Lines        4799     4799              
==========================================
- Hits         4617     4613       -4     
- Misses        182      186       +4     
Flag Coverage Δ
unittests 96.12% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/models/recognition/predictor/tensorflow.py 91.17% <0.00%> (-5.89%) ⬇️
doctr/models/builder.py 97.36% <0.00%> (-1.76%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45e1647...3f3ffce. Read the comment docs.

Copy link
Collaborator

@charlesmindee charlesmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR

@fg-mindee fg-mindee merged commit 106a1e1 into main Dec 26, 2021
@fg-mindee fg-mindee deleted the contiguous branch December 26, 2021 13:57
@fg-mindee fg-mindee added the type: enhancement Improvement label Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: references Related to references folder framework: pytorch Related to PyTorch backend topic: ci Related to CI type: enhancement Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants