Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added dedicated evaluation scripts for text detection #761

Merged
merged 2 commits into from
Dec 27, 2021

Conversation

fg-mindee
Copy link
Contributor

@fg-mindee fg-mindee commented Dec 26, 2021

This PR introduces the following modifications:

  • adds scripts to evaluate text detection models on supported datasets
  • adds the perf report as a .csv

I'll have to open another PR for text recognition because the crop needs to be made live efficiently. Those PRs aim at speeding up evaluation runs for models once they are trained

Any feedback is welcome!

@fg-mindee fg-mindee added benchmark This issue reports a benchmark ext: references Related to references folder framework: pytorch Related to PyTorch backend framework: tensorflow Related to TensorFlow backend topic: text detection Related to the task of text detection labels Dec 26, 2021
@fg-mindee fg-mindee added this to the 0.5.0 milestone Dec 26, 2021
@fg-mindee fg-mindee self-assigned this Dec 26, 2021
@fg-mindee fg-mindee added the type: enhancement Improvement label Dec 26, 2021
@codecov
Copy link

codecov bot commented Dec 26, 2021

Codecov Report

Merging #761 (e1b4f16) into main (56a5830) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #761      +/-   ##
==========================================
+ Coverage   96.22%   96.28%   +0.06%     
==========================================
  Files         129      129              
  Lines        4764     4764              
==========================================
+ Hits         4584     4587       +3     
+ Misses        180      177       -3     
Flag Coverage Δ
unittests 96.28% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/transforms/modules/base.py 94.44% <0.00%> (ø)
doctr/models/_utils.py 98.79% <0.00%> (+1.20%) ⬆️
doctr/models/recognition/predictor/tensorflow.py 97.05% <0.00%> (+5.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56a5830...e1b4f16. Read the comment docs.

Copy link
Collaborator

@charlesmindee charlesmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fg-mindee fg-mindee merged commit 6162a5d into main Dec 27, 2021
@fg-mindee fg-mindee deleted the evaluation-scripts branch December 27, 2021 11:20
@fg-mindee fg-mindee added type: new feature New feature and removed type: enhancement Improvement labels Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark This issue reports a benchmark ext: references Related to references folder framework: pytorch Related to PyTorch backend framework: tensorflow Related to TensorFlow backend topic: text detection Related to the task of text detection type: new feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants