-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add preserve aspect ratio to predictor and vizualisation utils #766
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, a few improvement suggestions in the review!
Codecov Report
@@ Coverage Diff @@
## main #766 +/- ##
==========================================
- Coverage 96.19% 96.13% -0.07%
==========================================
Files 129 129
Lines 4810 4812 +2
==========================================
- Hits 4627 4626 -1
- Misses 183 186 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again!
This PR allows to use the
preserve_aspect_ratio
flag in the predictor:Yields:
Instead of:
Any feedback is welcome!