Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fixed TensorFlow predictor unittest #767

Merged
merged 1 commit into from
Dec 29, 2021
Merged

test: Fixed TensorFlow predictor unittest #767

merged 1 commit into from
Dec 29, 2021

Conversation

fg-mindee
Copy link
Contributor

This PR reduces the number of crops processed in unittests by using a pretrained detection model. It changed the number of crops from several thousands to a maximum of a few dozens.

It also prevents degraded localization candidates, and will hopefully fix the ongoing issue with current PR unittests in TensorFlow.

Any feedback is welcome!

@fg-mindee fg-mindee added ext: tests Related to tests folder framework: tensorflow Related to TensorFlow backend labels Dec 28, 2021
@fg-mindee fg-mindee added this to the 0.5.0 milestone Dec 28, 2021
@fg-mindee fg-mindee self-assigned this Dec 28, 2021
@codecov
Copy link

codecov bot commented Dec 28, 2021

Codecov Report

Merging #767 (2cf3965) into main (f2f1f21) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #767      +/-   ##
==========================================
- Coverage   96.19%   96.15%   -0.05%     
==========================================
  Files         129      129              
  Lines        4810     4810              
==========================================
- Hits         4627     4625       -2     
- Misses        183      185       +2     
Flag Coverage Δ
unittests 96.15% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/models/recognition/predictor/tensorflow.py 91.17% <0.00%> (-5.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2f1f21...2cf3965. Read the comment docs.

Copy link
Collaborator

@charlesmindee charlesmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@fg-mindee fg-mindee merged commit 0478b8b into main Dec 29, 2021
@fg-mindee fg-mindee deleted the tf-fix branch December 29, 2021 11:41
@fg-mindee fg-mindee added the type: bug Something isn't working label Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: tests Related to tests folder framework: tensorflow Related to TensorFlow backend type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants