Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Updated timing to more accurate one #769

Merged
merged 1 commit into from
Dec 29, 2021
Merged

feat: Updated timing to more accurate one #769

merged 1 commit into from
Dec 29, 2021

Conversation

fg-mindee
Copy link
Contributor

This PR simply replaces time.time() with time.perf_counter() which is much more recommended for latency benchmarks.

Any feedback is welcome!

@fg-mindee fg-mindee added type: enhancement Improvement ext: references Related to references folder labels Dec 29, 2021
@fg-mindee fg-mindee added this to the 0.5.0 milestone Dec 29, 2021
@fg-mindee fg-mindee self-assigned this Dec 29, 2021
Copy link
Collaborator

@charlesmindee charlesmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that !

@codecov
Copy link

codecov bot commented Dec 29, 2021

Codecov Report

Merging #769 (5960d3e) into main (8e7b0ee) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #769      +/-   ##
==========================================
+ Coverage   95.99%   96.01%   +0.02%     
==========================================
  Files         129      129              
  Lines        4818     4818              
==========================================
+ Hits         4625     4626       +1     
+ Misses        193      192       -1     
Flag Coverage Δ
unittests 96.01% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/transforms/modules/base.py 94.44% <0.00%> (ø)
doctr/models/builder.py 97.05% <0.00%> (+0.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e7b0ee...5960d3e. Read the comment docs.

@fg-mindee fg-mindee merged commit 47a3fc4 into main Dec 29, 2021
@fg-mindee fg-mindee deleted the latency branch December 29, 2021 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: references Related to references folder type: enhancement Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants