Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[datasets] unify np_dtype and fix comments #782

Merged
merged 50 commits into from
Jan 5, 2022

Conversation

felixdittrich92
Copy link
Contributor

@felixdittrich92 felixdittrich92 commented Jan 3, 2022

This PR:

  • unify np_dtype usage instead of np.float32
  • fix wrong comments or add missing
    @fg-mindee
  • fix wrong shape in SynthText if ndim != 3

Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
I agree, however I think the comment about polygons should be more specific. Perhaps something like:

# (x, y) coordinates of top left, top right, bottom right, bottom left corners

doctr/datasets/cord.py Outdated Show resolved Hide resolved
@fg-mindee fg-mindee self-assigned this Jan 3, 2022
@fg-mindee fg-mindee added ext: tests Related to tests folder module: datasets Related to doctr.datasets type: enhancement Improvement topic: documentation Improvements or additions to documentation and removed type: enhancement Improvement labels Jan 3, 2022
@fg-mindee fg-mindee added this to the 0.6.0 milestone Jan 3, 2022
@codecov
Copy link

codecov bot commented Jan 3, 2022

Codecov Report

Merging #782 (1f0f5ca) into main (e5ca2d5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #782   +/-   ##
=======================================
  Coverage   95.99%   95.99%           
=======================================
  Files         130      130           
  Lines        4870     4873    +3     
=======================================
+ Hits         4675     4678    +3     
  Misses        195      195           
Flag Coverage Δ
unittests 95.99% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/datasets/doc_artefacts.py 93.93% <ø> (ø)
doctr/datasets/ic03.py 97.36% <ø> (ø)
doctr/datasets/ic13.py 96.15% <ø> (ø)
doctr/datasets/iiit5k.py 96.77% <ø> (ø)
doctr/datasets/ocr.py 92.30% <ø> (ø)
doctr/datasets/sroie.py 96.87% <ø> (ø)
doctr/datasets/svhn.py 94.73% <ø> (ø)
doctr/datasets/svt.py 97.22% <ø> (ø)
doctr/datasets/cord.py 97.43% <100.00%> (+0.06%) ⬆️
doctr/datasets/detection.py 95.65% <100.00%> (+0.19%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5ca2d5...1f0f5ca. Read the comment docs.

Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Only a question about a transpose that you changed 👌

doctr/datasets/synthtext.py Show resolved Hide resolved
Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Felix!

@fg-mindee fg-mindee merged commit e14e643 into mindee:main Jan 5, 2022
@felixdittrich92 felixdittrich92 deleted the comment-dtype branch January 10, 2022 15:34
@frgfm frgfm mentioned this pull request Jun 28, 2022
85 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: tests Related to tests folder module: datasets Related to doctr.datasets topic: documentation Improvements or additions to documentation type: enhancement Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants