-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[datasets] unify np_dtype and fix comments #782
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
I agree, however I think the comment about polygons should be more specific. Perhaps something like:
# (x, y) coordinates of top left, top right, bottom right, bottom left corners
ea3622f
to
1f0f5ca
Compare
Codecov Report
@@ Coverage Diff @@
## main #782 +/- ##
=======================================
Coverage 95.99% 95.99%
=======================================
Files 130 130
Lines 4870 4873 +3
=======================================
+ Hits 4675 4678 +3
Misses 195 195
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Only a question about a transpose that you changed 👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Felix!
This PR:
np_dtype
usage instead ofnp.float32
@fg-mindee