Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show sample when batch size is 1 #787

Merged
merged 1 commit into from
Jan 10, 2022
Merged

fix: show sample when batch size is 1 #787

merged 1 commit into from
Jan 10, 2022

Conversation

charlesmindee
Copy link
Collaborator

this PR fixes the show_sample function when the batch size is 1

Any feedback is welcome!

@charlesmindee charlesmindee self-assigned this Jan 6, 2022
@charlesmindee charlesmindee added ext: references Related to references folder topic: object detection Related to the task of object detection type: bug Something isn't working labels Jan 6, 2022
@charlesmindee charlesmindee added this to the 0.5.1 milestone Jan 6, 2022
@codecov
Copy link

codecov bot commented Jan 6, 2022

Codecov Report

Merging #787 (db4d4d5) into main (e14e643) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #787   +/-   ##
=======================================
  Coverage   96.06%   96.06%           
=======================================
  Files         130      130           
  Lines        4901     4901           
=======================================
  Hits         4708     4708           
  Misses        193      193           
Flag Coverage Δ
unittests 96.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/transforms/modules/base.py 94.59% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e14e643...db4d4d5. Read the comment docs.

Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@charlesmindee charlesmindee merged commit fd850e5 into main Jan 10, 2022
@charlesmindee charlesmindee deleted the fix_show branch January 10, 2022 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: references Related to references folder topic: object detection Related to the task of object detection type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants