Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fixed PR label check job #792

Merged
merged 3 commits into from
Jan 10, 2022
Merged

ci: Fixed PR label check job #792

merged 3 commits into from
Jan 10, 2022

Conversation

fg-mindee
Copy link
Contributor

@fg-mindee fg-mindee commented Jan 10, 2022

In order to better automate release notes, this PR fixes the PR label check action.

To illustrate this, I didn't add all required labels to this PR (needs one of the primary labels, AND one of the secondary labels defined in https://github.com/mindee/doctr/blob/pr-labels/.github/verify_pr_labels.py). Once merged, the bot will ping me (since I will merge it) to remind me to correctly label the PR.

Any feedback is welcome!

@fg-mindee fg-mindee added the topic: ci Related to CI label Jan 10, 2022
@fg-mindee fg-mindee added this to the 0.5.1 milestone Jan 10, 2022
@fg-mindee fg-mindee self-assigned this Jan 10, 2022
@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

Merging #792 (3a856b5) into main (e14e643) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #792   +/-   ##
=======================================
  Coverage   96.06%   96.06%           
=======================================
  Files         130      130           
  Lines        4901     4901           
=======================================
  Hits         4708     4708           
  Misses        193      193           
Flag Coverage Δ
unittests 96.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/transforms/modules/base.py 94.59% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e14e643...3a856b5. Read the comment docs.

Copy link
Collaborator

@charlesmindee charlesmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fg-mindee fg-mindee merged commit d66ecc5 into main Jan 10, 2022
@fg-mindee fg-mindee deleted the pr-labels branch January 10, 2022 14:09
@fg-mindee fg-mindee added the type: bug Something isn't working label Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: ci Related to CI type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants