feat: add straight-eval arg in evaluate script #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlesmindee
added
ext: scripts
Codecov Report
@@ Coverage Diff @@
## main #793 +/- ##
==========================================
- Coverage 96.06% 96.00% -0.06%
==========================================
Files 130 131 +1
Lines 4901 4937 +36
==========================================
+ Hits 4708 4740 +32
- Misses 193 197 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
The CI job for the evaluate script is failing :/ |
fg-mindee
reviewed
Jan 13, 2022
fg-mindee
previously approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a straight-eval arg in the evaluate script to allow using the metrics with straight bounding boxes while using a detection predictor working with polygons (assume straight pages can be False).
I also fixed a bug in the predictor to cast to numpy before calling the extraction function (when we use a dataset we have tf/pt tensors otherwise)
Any feedback is welcome!