Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rotated linknet_resnet18 tensorflow ckpts #817

Merged
merged 15 commits into from
Mar 9, 2022
Merged

Conversation

charlesmindee
Copy link
Collaborator

Following #816, this PR adds the checkpoints of the trained linket_resnet18 on rotated samples.
Any feedback is welcome!

@charlesmindee charlesmindee added type: enhancement Improvement module: models Related to doctr.models framework: tensorflow Related to TensorFlow backend topic: text detection Related to the task of text detection labels Feb 14, 2022
@charlesmindee charlesmindee added this to the 0.5.1 milestone Feb 14, 2022
@charlesmindee charlesmindee self-assigned this Feb 14, 2022
@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #817 (1adf93e) into main (0310d6c) will decrease coverage by 0.29%.
The diff coverage is 86.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #817      +/-   ##
==========================================
- Coverage   95.99%   95.69%   -0.30%     
==========================================
  Files         131      133       +2     
  Lines        5042     5133      +91     
==========================================
+ Hits         4840     4912      +72     
- Misses        202      221      +19     
Flag Coverage Δ
unittests 95.69% <86.46%> (-0.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/models/zoo.py 100.00% <ø> (ø)
doctr/models/predictor/base.py 81.81% <53.84%> (-18.19%) ⬇️
doctr/models/detection/linknet/tensorflow.py 96.59% <66.66%> (-1.09%) ⬇️
doctr/transforms/modules/pytorch.py 94.52% <84.61%> (-3.79%) ⬇️
doctr/transforms/modules/tensorflow.py 92.90% <90.90%> (-0.16%) ⬇️
doctr/transforms/functional/base.py 95.65% <95.23%> (+1.90%) ⬆️
doctr/io/pdf.py 100.00% <100.00%> (+1.66%) ⬆️
doctr/io/reader.py 100.00% <100.00%> (ø)
doctr/models/detection/linknet/base.py 88.79% <100.00%> (ø)
doctr/models/detection/zoo.py 96.00% <100.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2581daa...1adf93e. Read the comment docs.

@fg-mindee
Copy link
Contributor

There are conflicts to be resolved if we are to move forward with the PR :)

@fg-mindee
Copy link
Contributor

ping @charlesmindee :)

Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the recent changes on the loss, I think there has some conflicts to resolve before moving on with this!

Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isort isn't happy but the rest is good 👍

@fg-mindee fg-mindee added type: new feature New feature and removed type: enhancement Improvement labels Mar 9, 2022
Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@charlesmindee charlesmindee merged commit 436053d into main Mar 9, 2022
@charlesmindee charlesmindee deleted the linknet_ckpt branch March 9, 2022 16:54
@fg-mindee fg-mindee mentioned this pull request Mar 9, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework: tensorflow Related to TensorFlow backend module: models Related to doctr.models topic: text detection Related to the task of text detection type: new feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants