-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor][fix]: Part1 from use datasets for recognition task #889
Conversation
Codecov Report
@@ Coverage Diff @@
## main #889 +/- ##
==========================================
+ Coverage 94.92% 94.93% +0.01%
==========================================
Files 133 133
Lines 5280 5293 +13
==========================================
+ Hits 5012 5025 +13
Misses 268 268
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Will add a missing test tommorow |
@charlesmindee can you review this PR please? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this first step, it is indeed a good idea to use datasets for both tasks
@charlesmindee @frgfm
Not much to review in this PR only a view slight modifications & preparations for the following PR 馃
modifications:
extract_crops
andextract_rcrops
to geometry for reuse (otherwise fails with circular imports)tensor_from_numpy
dataset/utils
Link to PoC: #867