Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor][fix]: Part1 from use datasets for recognition task #889

Merged
merged 27 commits into from
Apr 13, 2022

Conversation

felixdittrich92
Copy link
Contributor

@felixdittrich92 felixdittrich92 commented Apr 7, 2022

@charlesmindee @frgfm
Not much to review in this PR only a view slight modifications & preparations for the following PR 馃

modifications:

  • move extract_crops and extract_rcrops to geometry for reuse (otherwise fails with circular imports)
  • fix 2 dataset boxes
  • add tensor_from_numpy
  • add minor additional tests for dataset/utils

Link to PoC: #867

@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #889 (7ddb39a) into main (2c697ff) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #889      +/-   ##
==========================================
+ Coverage   94.92%   94.93%   +0.01%     
==========================================
  Files         133      133              
  Lines        5280     5293      +13     
==========================================
+ Hits         5012     5025      +13     
  Misses        268      268              
Flag Coverage 螖
unittests 94.93% <100.00%> (+0.01%) 猬嗭笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
doctr/datasets/datasets/pytorch.py 100.00% <100.00%> (酶)
doctr/datasets/datasets/tensorflow.py 100.00% <100.00%> (酶)
doctr/datasets/utils.py 95.83% <100.00%> (+0.59%) 猬嗭笍
doctr/models/_utils.py 96.00% <100.00%> (-1.60%) 猬囷笍
doctr/models/predictor/base.py 82.08% <100.00%> (+0.27%) 猬嗭笍
doctr/utils/geometry.py 100.00% <100.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 2c697ff...7ddb39a. Read the comment docs.

@felixdittrich92
Copy link
Contributor Author

Will add a missing test tommorow

@fharper
Copy link
Contributor

fharper commented Apr 8, 2022

@charlesmindee can you review this PR please? :)

Copy link
Collaborator

@charlesmindee charlesmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this first step, it is indeed a good idea to use datasets for both tasks

@charlesmindee charlesmindee merged commit 1a4e4df into mindee:main Apr 13, 2022
@felixdittrich92 felixdittrich92 deleted the crop-1 branch April 13, 2022 18:54
@frgfm frgfm added type: enhancement Improvement module: models Related to doctr.models module: utils Related to doctr.utils ext: tests Related to tests folder module: datasets Related to doctr.datasets labels May 2, 2022
@felixdittrich92 felixdittrich92 added this to the 0.6.0 milestone Jun 28, 2022
@felixdittrich92 felixdittrich92 mentioned this pull request Jun 29, 2022
85 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: tests Related to tests folder module: datasets Related to doctr.datasets module: models Related to doctr.models module: utils Related to doctr.utils type: enhancement Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants