Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature][tf/pt] integrate from_hub for all tasks #892

Merged
merged 34 commits into from
Apr 22, 2022

Conversation

felixdittrich92
Copy link
Contributor

@felixdittrich92 felixdittrich92 commented Apr 13, 2022

This PR:

  • follow up on @fg-mindee from_hub for all tasks (TF and PT)
  • fixes classification archs for push to hub which was not on track

TODO:

  • upload dummy models to hub for all working models (exclude other ftm in tests)
  • test for each uploaded model
  • test whole workflow (push to hub / load from hub)

Documentation will follow in another PR (maybe same after datasets PR merge which needs also documentation)

@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

Merging #892 (70c3749) into main (1a4e4df) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #892      +/-   ##
==========================================
- Coverage   94.71%   94.68%   -0.04%     
==========================================
  Files         135      133       -2     
  Lines        5375     5377       +2     
==========================================
  Hits         5091     5091              
- Misses        284      286       +2     
Flag Coverage Δ
unittests 94.68% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/models/classification/zoo.py 100.00% <100.00%> (+4.54%) ⬆️
doctr/models/detection/zoo.py 96.29% <100.00%> (ø)
doctr/models/factory/hub.py 74.69% <100.00%> (+8.56%) ⬆️
doctr/transforms/functional/base.py 95.65% <0.00%> (-1.45%) ⬇️
doctr/models/recognition/master/pytorch.py 91.74% <0.00%> (-0.92%) ⬇️
doctr/models/recognition/sar/pytorch.py 99.20% <0.00%> (-0.80%) ⬇️
doctr/transforms/modules/base.py 94.59% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a4e4df...70c3749. Read the comment docs.

@felixdittrich92 felixdittrich92 marked this pull request as ready for review April 14, 2022 12:22
@felixdittrich92
Copy link
Contributor Author

@charlesmindee wdyt?

Copy link
Collaborator

@charlesmindee charlesmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the integration!

@charlesmindee charlesmindee merged commit 43e5da3 into mindee:main Apr 22, 2022
@felixdittrich92 felixdittrich92 deleted the from-hub branch April 22, 2022 09:49
@frgfm frgfm added module: models Related to doctr.models framework: pytorch Related to PyTorch backend framework: tensorflow Related to TensorFlow backend type: new feature New feature ext: docs Related to docs folder labels May 2, 2022
@felixdittrich92 felixdittrich92 added this to the 0.6.0 milestone Jun 28, 2022
@felixdittrich92 felixdittrich92 mentioned this pull request Jun 29, 2022
85 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: docs Related to docs folder framework: pytorch Related to PyTorch backend framework: tensorflow Related to TensorFlow backend module: models Related to doctr.models type: new feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants