Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] imgur5k test #903

Merged
merged 32 commits into from
Apr 28, 2022
Merged

[Fix] imgur5k test #903

merged 32 commits into from
Apr 28, 2022

Conversation

felixdittrich92
Copy link
Contributor

@felixdittrich92 felixdittrich92 commented Apr 28, 2022

This PR fixes the failing imgur5k test:

  • inconsistent number of boxes samples yields to different numbers of samples in the test
  • now each sample has the same number of boxes to avoid random numbers of samples (recognition test)

@felixdittrich92 felixdittrich92 marked this pull request as draft April 28, 2022 11:44
@felixdittrich92 felixdittrich92 changed the title [Fix] imgur-5k test [Fix] imgur5k test Apr 28, 2022
@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #903 (debf4f4) into main (56b914c) will increase coverage by 0.02%.
The diff coverage is 95.65%.

@@            Coverage Diff             @@
##             main     #903      +/-   ##
==========================================
+ Coverage   94.70%   94.73%   +0.02%     
==========================================
  Files         133      134       +1     
  Lines        5442     5465      +23     
==========================================
+ Hits         5154     5177      +23     
  Misses        288      288              
Flag Coverage Δ
unittests 94.73% <95.65%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/datasets/mjsynth.py 95.45% <95.45%> (ø)
doctr/datasets/__init__.py 100.00% <100.00%> (ø)
doctr/transforms/modules/base.py 94.59% <0.00%> (ø)
doctr/transforms/functional/base.py 97.10% <0.00%> (+1.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9a1912...debf4f4. Read the comment docs.

@felixdittrich92 felixdittrich92 marked this pull request as ready for review April 28, 2022 12:35
@felixdittrich92
Copy link
Contributor Author

@charlesmindee

Copy link
Collaborator

@charlesmindee charlesmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@charlesmindee charlesmindee merged commit dc35d40 into mindee:main Apr 28, 2022
@felixdittrich92 felixdittrich92 deleted the fix-test branch April 28, 2022 13:30
@felixdittrich92 felixdittrich92 added type: bug Something isn't working ext: tests Related to tests folder module: datasets Related to doctr.datasets labels May 2, 2022
@felixdittrich92 felixdittrich92 added this to the 0.6.0 milestone Jun 29, 2022
@felixdittrich92 felixdittrich92 mentioned this pull request Jun 29, 2022
85 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: tests Related to tests folder module: datasets Related to doctr.datasets type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants