Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add swagger ping in API CI job #906

Merged
merged 1 commit into from
May 2, 2022
Merged

Conversation

frgfm
Copy link
Collaborator

@frgfm frgfm commented Apr 29, 2022

Following up on #847, this PR introduces the following modification:

  • adds a step in CI job for API, to ping the swagger before running the unittest

Presumably, if the behaviour described in #847, the CI should fail on this PR.

Any feedback is welcome!

@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #906 (de829ce) into main (3d645ce) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #906   +/-   ##
=======================================
  Coverage   94.73%   94.73%           
=======================================
  Files         134      134           
  Lines        5472     5472           
=======================================
  Hits         5184     5184           
  Misses        288      288           
Flag Coverage Δ
unittests 94.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d645ce...de829ce. Read the comment docs.

@felixdittrich92 felixdittrich92 added topic: ci Related to CI topic: docker Docker-related ext: api Related to api folder labels May 2, 2022
Copy link
Collaborator

@charlesmindee charlesmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@charlesmindee charlesmindee merged commit 0669fcf into mindee:main May 2, 2022
@frgfm frgfm deleted the docker-fix branch May 2, 2022 16:02
@frgfm frgfm added the type: enhancement Improvement label May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: api Related to api folder topic: ci Related to CI topic: docker Docker-related type: enhancement Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants