Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support page in README #946

Merged
merged 2 commits into from
Jun 10, 2022
Merged

Add support page in README #946

merged 2 commits into from
Jun 10, 2022

Conversation

jonathanMindee
Copy link
Contributor

No description provided.

@fharper fharper self-requested a review June 10, 2022 19:12
@fharper fharper added the type: misc Miscellaneous label Jun 10, 2022
@fharper
Copy link
Contributor

fharper commented Jun 10, 2022

@charlesmindee: I'm merging this PR, but seems like all images in the README are from the changelog of a release, so you had no img folder. I created one, but feel free to re-organize.

Copy link
Contributor

@fharper fharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #946 (391f5c6) into main (fddceba) will not change coverage.
The diff coverage is n/a.

❗ Current head 391f5c6 differs from pull request most recent head f69d1a2. Consider uploading reports for the commit f69d1a2 to get more accurate results

@@           Coverage Diff           @@
##             main     #946   +/-   ##
=======================================
  Coverage   94.83%   94.83%           
=======================================
  Files         134      134           
  Lines        5539     5539           
=======================================
  Hits         5253     5253           
  Misses        286      286           
Flag Coverage Δ
unittests 94.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fddceba...f69d1a2. Read the comment docs.

@fharper fharper merged commit 97da310 into main Jun 10, 2022
@fharper fharper deleted the jonathanMindee/support branch June 10, 2022 19:31
@github-actions
Copy link

Hey @fharper 👋
You merged this PR, but it is not correctly labeled. The list of valid labels is available at https://github.com/mindee/doctr/blob/main/.github/verify_pr_labels.py

@fharper fharper added the topic: documentation Improvements or additions to documentation label Jun 13, 2022
@frgfm frgfm added type: enhancement Improvement and removed type: misc Miscellaneous labels Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: documentation Improvements or additions to documentation type: enhancement Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants