Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

update pypdfium2 dep and improve code quality #953

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

felixdittrich92
Copy link
Contributor

This PR:

Any feedback is welcome 馃

@felixdittrich92 felixdittrich92 added module: io Related to doctr.io type: code quality Related to code quality labels Jun 17, 2022
@felixdittrich92 felixdittrich92 added this to the 0.5.2 milestone Jun 17, 2022
@felixdittrich92 felixdittrich92 self-assigned this Jun 17, 2022
@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

Merging #953 (d0efc48) into main (210ecc4) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #953      +/-   ##
==========================================
- Coverage   94.83%   94.81%   -0.02%     
==========================================
  Files         134      134              
  Lines        5539     5537       -2     
==========================================
- Hits         5253     5250       -3     
- Misses        286      287       +1     
Flag Coverage 螖
unittests 94.81% <100.00%> (-0.02%) 猬囷笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
doctr/io/pdf.py 92.30% <100.00%> (-1.03%) 猬囷笍
doctr/transforms/functional/base.py 95.65% <0.00%> (-1.45%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 210ecc4...d0efc48. Read the comment docs.

@mara004
Copy link
Contributor

mara004 commented Jun 17, 2022

Looks good, then!

Copy link
Collaborator

@frgfm frgfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Felix, I was about to open a PR for this specifically :)
We should update the version specifiers of other dependencies accordingly I think

@frgfm frgfm added type: enhancement Improvement topic: build Related to dependencies and build labels Jun 23, 2022
@frgfm frgfm merged commit 78c9105 into mindee:main Jun 23, 2022
@felixdittrich92
Copy link
Contributor Author

Thanks Felix, I was about to open a PR for this specifically :)
We should update the version specifiers of other dependencies accordingly I think

馃槄

About the deps part let us check if we can handle this with depend-a-bot this would make it much easier (really) ^^

@felixdittrich92 felixdittrich92 deleted the pypdfium2-update branch June 24, 2022 02:56
@frgfm
Copy link
Collaborator

frgfm commented Jun 25, 2022

That is a different problem though: dependabot is (to the best of my knowledge) reporting version specifier updates for security reasons

Here we need to reassess the upper and lower bound of each dep: I'll take care of it, and then set the dependabot 馃憤

@frgfm frgfm mentioned this pull request Jun 28, 2022
14 tasks
@felixdittrich92 felixdittrich92 mentioned this pull request Sep 26, 2022
85 tasks
@felixdittrich92 felixdittrich92 modified the milestones: 0.5.2, 0.6.0 Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: io Related to doctr.io topic: build Related to dependencies and build type: code quality Related to code quality type: enhancement Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants