-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
update pypdfium2 dep and improve code quality #953
Conversation
Codecov Report
@@ Coverage Diff @@
## main #953 +/- ##
==========================================
- Coverage 94.83% 94.81% -0.02%
==========================================
Files 134 134
Lines 5539 5537 -2
==========================================
- Hits 5253 5250 -3
- Misses 286 287 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Looks good, then! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Felix, I was about to open a PR for this specifically :)
We should update the version specifiers of other dependencies accordingly I think
馃槄 About the deps part let us check if we can handle this with depend-a-bot this would make it much easier (really) ^^ |
That is a different problem though: dependabot is (to the best of my knowledge) reporting version specifier updates for security reasons Here we need to reassess the upper and lower bound of each dep: I'll take care of it, and then set the dependabot 馃憤 |
This PR:
Any feedback is welcome 馃