Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] SVT dataset: clip box values and add shape and label check #955

Merged
merged 1 commit into from
Jun 24, 2022

Conversation

felixdittrich92
Copy link
Contributor

This PR:

  • clip box values and add shape and label check

Any feedback is welcome 馃

Please merge #954 before this one :)

@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

Merging #955 (abac30c) into main (210ecc4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #955   +/-   ##
=======================================
  Coverage   94.83%   94.83%           
=======================================
  Files         134      134           
  Lines        5539     5540    +1     
=======================================
+ Hits         5253     5254    +1     
  Misses        286      286           
Flag Coverage 螖
unittests 94.83% <100.00%> (+<0.01%) 猬嗭笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
doctr/datasets/svt.py 97.67% <100.00%> (+0.05%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 210ecc4...abac30c. Read the comment docs.

Copy link
Collaborator

@frgfm frgfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Only one question about the target format

doctr/datasets/svt.py Show resolved Hide resolved
Copy link
Collaborator

@charlesmindee charlesmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@charlesmindee charlesmindee merged commit c104c17 into mindee:main Jun 24, 2022
@felixdittrich92 felixdittrich92 deleted the fix-svt branch June 24, 2022 19:36
@frgfm frgfm mentioned this pull request Jun 28, 2022
85 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: datasets Related to doctr.datasets type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants