Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] MJSynth dataset: filter corrupted or missing images #956

Merged
merged 3 commits into from
Jun 24, 2022

Conversation

felixdittrich92
Copy link
Contributor

This PR:

  • filter corrupted or missing images

Any feedback is welcome 馃

Please merge #954 before this one :)

@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #956 (93e9400) into main (210ecc4) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #956      +/-   ##
==========================================
- Coverage   94.83%   94.82%   -0.02%     
==========================================
  Files         134      134              
  Lines        5539     5541       +2     
==========================================
+ Hits         5253     5254       +1     
- Misses        286      287       +1     
Flag Coverage 螖
unittests 94.82% <100.00%> (-0.02%) 猬囷笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
doctr/datasets/mjsynth.py 95.83% <100.00%> (+0.37%) 猬嗭笍
doctr/transforms/functional/base.py 95.65% <0.00%> (-1.45%) 猬囷笍
doctr/transforms/modules/base.py 94.59% <0.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 210ecc4...93e9400. Read the comment docs.

@frgfm frgfm modified the milestones: 0.6.0, 0.5.2 Jun 23, 2022
Copy link
Collaborator

@frgfm frgfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Felix :)

@felixdittrich92 felixdittrich92 merged commit fc90306 into mindee:main Jun 24, 2022
@felixdittrich92 felixdittrich92 deleted the fix-mjsynth branch June 24, 2022 02:56
@frgfm frgfm mentioned this pull request Jun 28, 2022
14 tasks
@felixdittrich92 felixdittrich92 mentioned this pull request Sep 26, 2022
85 tasks
@felixdittrich92 felixdittrich92 modified the milestones: 0.5.2, 0.6.0 Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: datasets Related to doctr.datasets type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants