chg: ♻️ make count_occurences a method of ExecNode #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bashirmindee
force-pushed
the
refacto-execnode
branch
from
877c411
to
9c1ff2b
Compare
bashirmindee
requested review from
matthiasmindee and
WassimMindee
as code owners
matthiasmindee
requested changes
Jan 29, 2024
|
|
||
| return new_lxn._usage_exec_node # type: ignore[return-value] | ||
| lxn: LazyExecNode[P, RVXN] = LazyExecNode(**values) | ||
| lxn._validate_dependencies() |
There was a problem hiding this comment.
same question than before here, why isn't it done in the init ?
There was a problem hiding this comment.
because we initailize LazyExecNodes in DAG.config_from_dict. And during that phase, we don't have any data in the global variable exec_nodes
There was a problem hiding this comment.
hmm then maybe we should consider not having this a method
There was a problem hiding this comment.
ok I can remove the code from this method and put it directly in the __call__...
I only did it to refactor the code a little bit and make the call tinier
There was a problem hiding this comment.
actually I just further thought about it... I think I have a solution for both cases!
bashirmindee
force-pushed
the
refacto-execnode
branch
from
9c1ff2b
to
2146595
Compare
WassimMindee
approved these changes
Jan 29, 2024
|
ok when the CI passes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: