When creating true socket connection, use host and port stored in instance variables, not in the Mocket class's variable #222
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #221
The issue was caused by how
Mocket._address
was used to determine which host and port to connect to inMocketSocket.true_sendall
.Mocket._address
gets overwritten when anotherMocketSocket
instance'sconnect
method gets called and could be the wrong address to use in that case.This PR fixes the issue by referencing the current instance's
_host
and_port
attributes instead.I see that, in
MocketSocket.getpeercert
, there's code that accounts for the case where_host
and_port
are not set to truthy values; not sure if that can happen intrue_sendall
as well and should be accounted for, or if the current simple fix will be enough (or maybe even that it'd be a different kind of bug if_host
and_port
aren't set by the timetrue_sendall
gets called).