fix(reduced queries): accept selection without directives #17

sclausen · 2022-04-21T06:40:18Z

fixes #16

sclausen · 2022-04-21T06:45:44Z

src/helpers/reducedQueries.js

@@ -139,7 +139,7 @@ const hasVariable = (selectionSet, variable) => (
        const isVariableInArguments = selection.arguments.some(({ value }) => (
            value?.name?.value === variable
        ));
-        const isVariableInDirectives = selection.directives.some((directive) => (
+        const isVariableInDirectives = (selection.directives || []).some((directive) => (
            directive.arguments.some(({ value }) => value?.name?.value === variable)


@mindnektar Or would it be wiser to also check if the directives arguments are also not an array?

…efined too

mindnektar · 2022-04-21T09:13:46Z

Good idea in theory, but unfortunately it doesn't fix the actual issue. The problem is that the hasVariable implementation assumes every selection it handles to be a field, but it could also be a fragment (or possibly something else). The query reduction feature works only with fields, so if hasVariable is facing anything else, it has to stop its current iteration and assume the variable needs to stay.

fix(reduced queries): accept selection without directives

f227c7d

sclausen commented Apr 21, 2022

View reviewed changes

fix(reduce queries): take into account that some variables may be und…

fe77b54

…efined too

mindnektar closed this Apr 21, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(reduced queries): accept selection without directives #17

fix(reduced queries): accept selection without directives #17

sclausen commented Apr 21, 2022

sclausen Apr 21, 2022

mindnektar commented Apr 21, 2022

fix(reduced queries): accept selection without directives #17

fix(reduced queries): accept selection without directives #17

Conversation

sclausen commented Apr 21, 2022

sclausen Apr 21, 2022

Choose a reason for hiding this comment

mindnektar commented Apr 21, 2022