Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UPDATE queries with JOINs #32

Closed
mindplay-dk opened this issue Jan 30, 2017 · 1 comment
Closed

Improve UPDATE queries with JOINs #32

mindplay-dk opened this issue Jan 30, 2017 · 1 comment
Milestone

Comments

@mindplay-dk
Copy link
Owner

UpdateQuery currently does not quote column-references - this could lead to collisions in multi-table update-queries where columns in different tables have identical names.

Ideally, quoting column-references should be done conditionally, e.g. only in update-queries that actually have joins.

@mindplay-dk mindplay-dk added this to the 1.0 milestone Jan 30, 2017
@mindplay-dk
Copy link
Owner Author

UpdateQuery currently does not quote column-references

This is incorrect: column references are definitely quoted, though perhaps I meant qualified, which they are not - but qualifying would be required only in multi-table updates, which aren't supported by the UPDATE statement in most databases, including Postgres.

While multi-table updates are supported in MySQL, I wouldn't count this as a bug, just a non-feature.

As this feature is very non-standard, and has some odd limitations in MySQL (which you can read about in the manual), I'm not going to support it at this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant