Bindgen feature #34
Merged
Bindgen feature #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the compilation to include this feature is slightly ungainly: # "standard" compilation
cargo buildThis is fair enough. cargo build --no-default-features --features bindgenThis is quite a lot of typing. I don't know if there is a way of disables to be exclusive? |
|
Currently the bindgen feature is not tested on travis, but is tested on push with my local .git hook |
|
It turns out getting clang 3.9 on travis is a pain :( |
|
We need to add some documentation to the README |
This swaps out compilation with `fitsio-sys` for compilation with `fitsio-sys-bindgen`. This relies on the user having clang>=3.9 installed on their system. Set up compilation for switching features (build error) Ensure code compiles and tests pass This mostly revolved around changing pointer types which were hard coded to cast to libc::c_void, whereas in `fitsio-sys-bindgen` they were `std::os::raw::c_void`. By using a wildcard cast (`_`) the code automatically casts to the correct value for both libraries. The other change was to move `MAX_VALUE_LENGTH` to `fitsio` rather than the low level library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow conditional compilation using compilation features
#33