Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bindgen feature #34

Merged
merged 2 commits into from May 7, 2017
Merged

Bindgen feature #34

merged 2 commits into from May 7, 2017

Commits on May 7, 2017

  1. Add bindgen feature

    This swaps out compilation with `fitsio-sys` for compilation with
    `fitsio-sys-bindgen`. This relies on the user having clang>=3.9
    installed on their system.
    
    Set up compilation for switching features (build error)
    
    Ensure code compiles and tests pass
    
    This mostly revolved around changing pointer types which were hard coded
    to cast to libc::c_void, whereas in `fitsio-sys-bindgen` they were
    `std::os::raw::c_void`. By using a wildcard cast (`_`) the code
    automatically casts to the correct value for both libraries.
    
    The other change was to move `MAX_VALUE_LENGTH` to `fitsio` rather than
    the low level library.
    simonrw committed May 7, 2017
    Copy the full SHA
    e2b0321 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    b1bcc17 View commit details
    Browse the repository at this point in the history