Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove type mapping #724

Merged
merged 5 commits into from Nov 8, 2021
Merged

Remove type mapping #724

merged 5 commits into from Nov 8, 2021

Conversation

George3d6
Copy link
Contributor

  • Json ai now requires explicit data_types for all the features instead of sourcing them from the namespace of the encoder
  • Removed "typed" encoder namespaces and their usage

@George3d6 George3d6 added the refactor Some part of the code is working ok for now, but for various reasons should be refactored label Nov 4, 2021
hakunanatasha
hakunanatasha approved these changes Nov 7, 2021
View reviewed changes
Copy link
Contributor

@hakunanatasha hakunanatasha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine.

@George3d6 George3d6 merged commit 533cdf5 into staging Nov 8, 2021
@paxcema paxcema mentioned this pull request Nov 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakunanatasha hakunanatasha hakunanatasha approved these changes

Assignees
No one assigned
Labels
refactor Some part of the code is working ok for now, but for various reasons should be refactored
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@George3d6 @hakunanatasha