Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Athena Handler #9282

Closed
wants to merge 28 commits into from
Closed

Athena Handler #9282

wants to merge 28 commits into from

Conversation

rwatts3
Copy link
Contributor

@rwatts3 rwatts3 commented Jun 1, 2024

Description

This pull request introduces the Athena Handler for MindsDB. The Athena Handler allows users to interact with Amazon Athena, an interactive query service for analyzing data in Amazon S3 using standard SQL. The handler was implemented using boto3, the AWS SDK for Python.

Type of change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ⚡ New feature (non-breaking change which adds functionality)
  • 📢 Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • 📄 This change requires a documentation update

Verification Process

To ensure the changes are working as expected:

  • Test Location: The testing can be done within the MindsDB integrations environment.
  • Verification Steps:
    1. Set up the required AWS credentials and S3 bucket.
    2. Use the provided SQL commands in the README to create a connection to Athena.
    3. Run sample queries to verify data retrieval from Athena.
    4. Verify that the connection arguments are correctly passed and used by the handler.

Additional Media:

  • I have attached a brief loom video or screenshots showcasing the new functionality or change.

Checklist:

  • My code follows the style guidelines (PEP 8) of MindsDB.
  • I have appropriately commented on my code, especially in complex areas.
  • Necessary documentation updates are either made or tracked in issues.
  • Relevant unit and integration tests are updated or added.

Copy link
Member

@ZoranPandovski ZoranPandovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @rwatts3 🙌 I've added few minor comments

@mindsdbadmin
Copy link
Contributor

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


0 out of 2 committers have signed the CLA.
@ryan Watts
@rwatts3
Ryan Watts, rwatts3 seem not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

@rwatts3
Copy link
Contributor Author

rwatts3 commented Jun 4, 2024

I have read the CLA Document and I hereby sign the CLA

@rwatts3
Copy link
Contributor Author

rwatts3 commented Jun 7, 2024

recheck

Copy link
Member

@ZoranPandovski ZoranPandovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rwatts3
Copy link
Contributor Author

rwatts3 commented Jun 13, 2024

@rwatts3
Copy link
Contributor Author

rwatts3 commented Jun 15, 2024

Anything else you need from me on this PR?

@ZoranPandovski
Copy link
Member

ZoranPandovski commented Jun 17, 2024

Hey @rwatts3, thanks; this is ready for merging, we just need to solve the CLA. I think locally you are logged in with one user and you don't have that git user linked to your GitHub account, that's why you can't sign the CLA. Can you please check that for more info check this link.

@rwatts3
Copy link
Contributor Author

rwatts3 commented Jun 20, 2024

recheck

@rwatts3 rwatts3 closed this Jun 25, 2024
@rwatts3 rwatts3 deleted the athena-handler branch June 25, 2024 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants