-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Athena Handler #9282
Athena Handler #9282
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @rwatts3 🙌 I've added few minor comments
mindsdb/integrations/handlers/athena_handler/tests/test_athena_handler.py
Outdated
Show resolved
Hide resolved
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA 0 out of 2 committers have signed the CLA. |
I have read the CLA Document and I hereby sign the CLA |
recheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rwatts3 please just fix the flake8 warnings https://github.com/mindsdb/mindsdb/actions/runs/9427301817/job/26010434799?pr=9282#step:6:75
Done here b4e8963 |
Anything else you need from me on this PR? |
Hey @rwatts3, thanks; this is ready for merging, we just need to solve the CLA. I think locally you are logged in with one user and you don't have that git user linked to your GitHub account, that's why you can't sign the CLA. Can you please check that for more info check this link. |
recheck |
Description
This pull request introduces the Athena Handler for MindsDB. The Athena Handler allows users to interact with Amazon Athena, an interactive query service for analyzing data in Amazon S3 using standard SQL. The handler was implemented using
boto3
, the AWS SDK for Python.Type of change
Verification Process
To ensure the changes are working as expected:
Additional Media:
Ryan Watts MindsDB - Athena Handler - Watch Video
Checklist: